passforios icon indicating copy to clipboard operation
passforios copied to clipboard

Build instructions outdated

Open mayo opened this issue 4 years ago • 2 comments

There are a few problems with the build instructions:

  1. Current instructions don't work and fail when running carthage update.

  2. The build requires relatively outdated software versions, like go 1.14 (now 1.16), CocoaPods 1.5.x (now 1.10.x), etc.

  3. The build instructions in Readme are somewhat different than instructions on the wiki. Which one is the correct way? The readme lists the instructions while also referring to the wiki at the same time.

  4. Required version of Carthage not listed.

mayo avatar May 24 '21 06:05 mayo

Have you had any luck getting it to build? Carthage seems to choke on objective-git for me…

I’m trying to replicate the instructions in the GitHub actions file, but objective-git just seems to be broken.

awensaunders avatar Jun 13 '21 23:06 awensaunders

Current instructions don't work and fail when running carthage update.

Make sure you execute the custom build script ./scripts/wcarthage to run Carthage.

The build requires relatively outdated software versions, like go 1.14 (now 1.16), CocoaPods 1.5.x (now 1.10.x), etc.

The Go part should be fixed with #477. I run CocoaPods 1.10.1 which works fine. The information is just outdated, I guess.

The build instructions in Readme are somewhat different than instructions on the wiki. Which one is the correct way? The readme lists the instructions while also referring to the wiki at the same time.

The instructions in the README are more up to date. I agree with you that there should only be one list of instructions. The README is preferable since it can be updated by PRs any time.

Required version of Carthage not listed.

I use the latest version 0.38.0 and it works fine if you build with the custom build script.

SimplyDanny avatar Jun 20 '21 10:06 SimplyDanny