mryellow
mryellow
@pansen The whole section dealing with schema parsing within responses seems to suffer from a multitude of bugs and definitely needs a re-write to support multiple response types. https://github.com/Mermade/widdershins/issues/436 https://github.com/Mermade/widdershins/issues/437
Yeah it's likely I'll be getting onto this one. Will finish working up the JSON part of my setup then move onto the markdown/html.
Current implementation of old fix to `onBrowserComplete`: https://github.com/karma-runner/karma-junit-reporter/blob/4c2abd00b99251757b6c53ee539979e4fb9c705f/index.js#L78-L80 Same idea in `writeXmlForBrowser`: https://github.com/karma-runner/karma-junit-reporter/blob/4c2abd00b99251757b6c53ee539979e4fb9c705f/index.js#L44-L46 Missing from `initliazeXmlForBrowser`. Think `browser.id` in `onBrowserComplete` may need checking also. Fixes are missing from `onBrowserComplete` here...
Not sure it needs a PR, linking master branch without commit hash, looks like it has everything: https://github.com/karma-runner/karma-junit-reporter/blob/master/index.js#L44-L46 https://github.com/karma-runner/karma-junit-reporter/blob/master/index.js#L78-L80 This one missing, could probably do with a check here too:...
Succeeds: * `A 10 10 0 0 0 100 100` * `A 10 10 0 0 0 100 200` * `A 10 10 0 0 0 100 250` Fails: *...
``` /* global describe, it */ import { createSVGDocument } from '../main-module.js' import assert from 'assert' describe('arc length', () => { it('obtaining arc length should not result in RangeError', ()...
Rather than bisecting over and over again `svg-path-properties` decides ahead of time how many segments to limit itself to. https://github.com/rveciana/svg-path-properties/blob/40d42d50729b2560dcfda2cf36e5d78b049a4f73/src/arc.ts#L253-L254
Could always decouple with `setTimeout` and return a promise... Though it seems a little out-of-place here.
I'd think return what you have on a `RangeError` though the way it's dividing and recusing down there isn't really a "what you have". Haven't gone back and reviewed what...
Ignoring for a moment that there is not much real commercial value to advertising impressions generated in this way. I can't imagine a future in 10 year where development is...