checkmake icon indicating copy to clipboard operation
checkmake copied to clipboard

Refactor/Update Dockerfile

Open PeterDaveHello opened this issue 5 years ago • 6 comments
trafficstars

Just a few adjustments to make the Docker image even better :tada:

PeterDaveHello avatar Apr 20 '20 10:04 PeterDaveHello

Hi @mrtazz, do you have a minute to take a look? Thanks.

PeterDaveHello avatar Jun 16 '21 11:06 PeterDaveHello

change looks good to me. But it seems there is a conflict with the Dockerfile in the default branch

mrtazz avatar Jun 21 '21 11:06 mrtazz

Cool, looks like there are multiple conflicts as the code base changed in the past year, I'll resolve them.

PeterDaveHello avatar Jun 21 '21 16:06 PeterDaveHello

Well... it's strange that I can't build the image any more, looks like something is broken during the past year...

PeterDaveHello avatar Jun 21 '21 16:06 PeterDaveHello

#51 sent to fix the build first, looks like it's a little bit messy there 😅

PeterDaveHello avatar Jun 21 '21 17:06 PeterDaveHello

@mrtazz conflicts resolved! Thanks.

PeterDaveHello avatar Sep 30 '21 12:09 PeterDaveHello

@mrtazz any chance to take a look? Thanks.

PeterDaveHello avatar May 07 '23 16:05 PeterDaveHello

Thanks for taking the time to contribute!

mrtazz avatar Aug 17 '23 11:08 mrtazz