dotenv-webpack icon indicating copy to clipboard operation
dotenv-webpack copied to clipboard

chore: removing babel

Open mrsteele opened this issue 6 years ago • 7 comments
trafficstars

mrsteele avatar Jan 18 '19 05:01 mrsteele

Codecov Report

Merging #161 into master will decrease coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   98.59%   98.43%   -0.16%     
==========================================
  Files           1        1              
  Lines          71       64       -7     
==========================================
- Hits           70       63       -7     
  Misses          1        1              
Impacted Files Coverage Δ
src/index.js 98.43% <100.00%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a7270d...fe56474. Read the comment docs.

codecov[bot] avatar Jan 18 '19 05:01 codecov[bot]

Hi @mrsteele Is removing babel still on the roadmap? Or upgrading to babel 7?

emanualjade avatar Aug 03 '19 19:08 emanualjade

It is! You got thoughts or feedback?!?

mrsteele avatar Aug 03 '19 19:08 mrsteele

I don't have any super useful feedback right up front.

My own codebase has a few packages using babel 6 that cause conflicts with babel v7. Part of which lead me to your PR. So was pretty excited to see this PR in progress and wanted to get a feel for where you were with this one. To see if it's close or if there are specific things that prevented it from being merged.

I'd need a bit of an upgrade on babel to be able to provide useful technical help. Of course not out of the question.

emanualjade avatar Aug 03 '19 19:08 emanualjade

This PR is essentially done. I was nervous to push the button because of the popularity of this, but also the worry of the impact of how much it would be supported on older versions of node

mrsteele avatar Aug 03 '19 19:08 mrsteele

I hear you on that. It does have quite a few users. On the other hand since this PR was crafted, babel 7 has gained quite a bit in popularity. Would a major version change of dotenv-webpack be enough to make forward movement with the PR?

Still supporting current users on the previous versions

hmmm. If really wanting to support older versions of node going forward maybe even then a different PR that just does an upgrade to Babel 7 and save this one for later when the time is right.

emanualjade avatar Aug 03 '19 20:08 emanualjade

@emanualjade Just wanted to mention this plugin is now using babel 7. Hopefully that solves some of the problems you were facing.

mrsteele avatar Jul 28 '20 12:07 mrsteele