react-native-multithreading icon indicating copy to clipboard operation
react-native-multithreading copied to clipboard

chore: update [email protected] and fix Use of undeclared identifier 'ShareableValue'

Open numandev1 opened this issue 4 years ago • 4 comments

numandev1 avatar Sep 30 '21 20:09 numandev1

how is the ShareableValue error fixed? by importing it at last?

mrousavy avatar Oct 04 '21 12:10 mrousavy

@mrousavy Yes, fixed by import #include <RNReanimated/ShareableValue.h after #include <RNReanimated/RuntimeManager.h>

numandev1 avatar Oct 04 '21 15:10 numandev1

@mrousavy I'm also experiencing this error use of undeclared identifier 'ShareableValue' which after locally moving the include of SharedValue.h after RuntimeManager.h resolves the build error.

It would be awesome to merge/ship this PR so that I don't have to patch/modify locally.

We're using react-native 0.66.0.

Thanks!

goleary avatar Dec 27 '21 22:12 goleary

Can we give this some attention because this is preventing me of using the library (unmodified)? Personally I'd get rid of the package changes though, and just focus on the .cpp.

callaars avatar Feb 17 '22 10:02 callaars