typescript-plugin-css-modules icon indicating copy to clipboard operation
typescript-plugin-css-modules copied to clipboard

"Find all references" feature doesn't work

Open dko-slapdash opened this issue 6 years ago • 3 comments

Thanks again for the plugin!

Looks like the feature "find all references to a particular css class" doesn't work in vscode.

Here is an animated GIF illustration:

Aug-14-2019 23-32-16

What's interesting is that if I run "Find all references" from the side of a tsx file, it ALMOST works. Here is a GIF showing how it "almost works" from that side:

Aug-14-2019 23-36-07

Looks like if it's run from the tsx side, the plugin messes up offset of css classes in the css file. (Could also be that it's the consequence of #34 bug.)

dko-slapdash avatar Aug 15 '19 06:08 dko-slapdash

I think this would be solved by #34 as you've pointed out... let me look into potential solutions for this.

mrmckeb avatar Aug 16 '19 07:08 mrmckeb

So, I've looked into this a little more and I think that the second issue may be fixed by #34, but the first issue won't be.

This would require a VSCode extension I believe, as this plugin (and TypeScript) aren't operational when the CSS file is open.

I've marked this as an enhancement, but I think this will only be partially fixable... Of course, that doesn't mean we shouldn't try :)

mrmckeb avatar Sep 07 '19 12:09 mrmckeb

This isn't working correctly as even with #34 solved, apologies. I'm not sure this is doable, as go to definition works now - yet the reference is still on the wrong line.

mrmckeb avatar Dec 04 '22 00:12 mrmckeb