Ewan McDougall

Results 45 comments of Ewan McDougall
trafficstars

Have tracked my issue with two pretender instances starting due to `isTesting` returning `false` to unrelated issue with different addon https://github.com/emberjs/ember-classic-decorator/issues/99

There is an incompatibility with how ActionDispatch::Integration::Session 4.2 detects if a rails app is being run and testing Grape API with rspec integration tests, it doesn't effect 4.1 ~or 5.0~....

@jcope2013 it's in spec_helper file, in my case `api_spec_helper.rb` which is included in all the rspec integration tests exercising the grape api in my project.

Ha! I didn't spot that @milgner and not using Rails 5 with Grape. So it's the same issue but you'll need to patch `create_session` for rails 5 instead in `initialize`,...

Working on rails 5.2.1 @zauzaj @jasonl ```ruby module ActionDispatch module Integration module Runner def create_session(app) klass = APP_SESSIONS[app] ||= Class.new(Integration::Session) { if app.respond_to?(:routes) && app.routes.respond_to?(:url_helpers) include app.routes.url_helpers include app.routes.mounted_helpers end...

Or put them both in with a conditional on rails version so your next rails upgrade is less work.

I can update README after any discussion about flags used

I saw your tracking issue https://github.com/miragejs/miragejs/issues/1013 and discussion https://github.com/miragejs/miragejs/issues/1037 @cah-brian-gantzler . Looking forward to trying miragejs with MSW. `didRequest` uses pretenders `handledRequest` hook. Reading mswjs it looks like [`onMockedResponse`](https://github.com/mswjs/msw/search?q=onMockedResponse) is...

Thanks, have set it up in large mirage project and working through migration issues.