timelapse icon indicating copy to clipboard operation
timelapse copied to clipboard

Published 20 hours ago • verified publisher icon mre

Add linter to Github actions

Open mre opened this issue 5 years ago • 3 comments

Description

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [X] Enhancement/optimization
  • [ ] Documentation

Issues Fixed or Closed by This PR

  • Add linting to the build process. See #33.

Checklist

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mre avatar Mar 13 '20 22:03 mre

@mre Wow this is turning out to be a lot of work, but looks great!

cmangla avatar Mar 16 '20 13:03 cmangla

@cmangla, yeah let's take it as an opportunity to clean up non-idiomatic code. I think the result is great: https://github.com/mre/timelapse/pull/45/commits/6e48d4885702e1799a63b219a05c3ae610a5ee80 If we all fix a few of those lints from time to time, we'll be in a much better position soon.

mre avatar Mar 16 '20 13:03 mre

Of course, after pylint, we still have mypy to tackle. And who knows what else. 😆

mre avatar Mar 16 '20 13:03 mre