Matthias Endler

Results 866 comments of Matthias Endler

* [ ] Try to use `rlimit` crate to detect resource limits and limit the number open files to that.

I think `rlimit` is the way to go to fix this once and for all (famous last words). In the meantime, your best bet is `--max-concurrency`, unfortunately.

> For remote URLs, always report `ErrorKind::NetworkRequest`. But allows `ErrorKind::ReadResponseBody` unless user specified. Maybe we have to handle the check for empty response body together with the status code. For...

For the same reason that ripgrep doesn't follow symlinks by default. https://github.com/BurntSushi/ripgrep/issues/692 We should introduce a flag to overwrite this behavior, though.

@lebensterben, any feedback on this? https://github.com/lycheeverse/lychee/issues/918#issuecomment-1385088847

Weird! I tried it locally inside a Docker container, and it worked for me. 🤔 Logs ~ ❯❯❯ docker run -it --rm menci/archlinuxarm [root@e089761b79ce /]# curl --proto '=https' --tlsv1.2 -sSf...

That looks like a flaky test to me as the code that the command runs is the same for this test. Can you run that single test a few times...

@orhun, can you run the following command manually? ```sh rm .lycheecache echo "slack://user\nhttps://example.com/" | lychee --cache --verbose --no-progress --exclude https://example.com - ``` The output should look *exactly* like this: ```sh...

Couple of action items: - Make each cache test run in a separate directory - Tests should run with `cargo test ` as well, just slower. If we want to...

There is not, and I didn't know that was a thing, but I'd be thankful for a pull request to add one.