three.js icon indicating copy to clipboard operation
three.js copied to clipboard

USDZExporter: Anchoring support

Open ThorstenBux opened this issue 4 years ago • 7 comments

Related issue: Fixed #21995

Description

Until these changes, it wasn't possible to tell AR Quicklook that a USDZ file should be attached to a wall target as opposed to a horizontal surface.

Reference: https://developer.apple.com/documentation/arkit/usdz_schemas_for_ar/preliminary_anchoringapi

This contribution is funded by Tripod Digital.

ThorstenBux avatar Jun 16 '21 07:06 ThorstenBux

I guess you can remove these console.log()s? Also, make sure you use tabs for indentation.

mrdoob avatar Jun 28 '21 16:06 mrdoob

Thank you @mrdoob for your feedback. I've changed the code accordingly.

ThorstenBux avatar Jul 06 '21 07:07 ThorstenBux

It seems there is still a merge conflict.

Mugen87 avatar Jul 06 '21 07:07 Mugen87

Hm, let me see

ThorstenBux avatar Jul 06 '21 07:07 ThorstenBux

Hmm, seems like you changed the indentation to spaces.

mrdoob avatar Jul 07 '21 14:07 mrdoob

arg, VS code auto indentation. I'm used to spaces

ThorstenBux avatar Jul 07 '21 20:07 ThorstenBux

There are still some indentation changes left.

Have a look at the diff: https://github.com/mrdoob/three.js/pull/21997/files

mrdoob avatar Jul 10 '21 17:07 mrdoob

Closing in favor of #22854.

Mugen87 avatar Oct 26 '22 10:10 Mugen87