Mahmoud Al-Qudsi comments

Results 365 comments of


                                            Mahmoud Al-Qudsi

trafficstars

If the prompt fills the entire line, clr_eol confuses some terminals

I think clearing first and outputting second (what you just reverted) would work if we used `^[[2K` instead of `clr_eol` (I don't know what curses calls it). That would clear...

Fix `fish_config theme save`

I pushed an update that addresses your concerns, @faho. (I didn't force push, but I'll squash the commits into the latter if we end up going with that direction). Note...

Fix `fish_config theme save`

Actually, thanks for reminding me to use `--names`. I've made that mistake before! I just pushed an update that does that; I think now we can comfortably use `fish_config theme...

git prompt: Interpret values as true for bools instead of relying on defined-or-not

I'm not sure how I feel about this. I agree that it should be possible to set them to some value to indicate that they are disabled, but to assume...

git prompt: Interpret values as true for bools instead of relying on defined-or-not

GitHub's default code search includes too many duplicates. [Using cs.github.com](https://cs.github.com/?q=__fish_git_prompt_show_informative_status&p=1&pt=bbebc12f2607dc8300fcafb29693e0bc4fb7bd916c7015ec941cfab9b4d8c4c020f84c21d3623947a562d369a4867d7c10deb0af415f7b5b51ca0aaf87460bdcc9fe667f466b4051c175de74b5f64bf70a46957d3a93060d0117894fef4165ed9b022f39f99fe5a6e66472841b5210c9b18a14b0dd151e4948dd15ac7ee06c664ca32c6e245d37ca1bd26e2f7387bb3c8670a62afb094658830caf57e3b0a6fa175718d5128a3f97d81b047a75e4bc5d5e05105882f599e46df462191f09ce6dd9e52927a89dd7baf83f9448d2c56a619786be021b9bb19d16b4e4a46222a867cf16a3ca7d1efcd5bc3ffcb5bb3afcb62a85bfec93025fd388ae0dca63aae721ce7fe5aca28cb68d860803179d74110602e6e53130876fff0873e34526cd3385f82bc61476aa1a476d8f9250a4e9351e0559dd4fcb2793fb992093329bba302fd3820bc6dd6d7971e872be8179f372985557659c468f94b0a8bf7d0fdd5dc5be0bc5b6994fb2f16cf8d01fafb21b023d9bbc66f59ba5faaa663338a970e05225c1448aec50f519b468b8125ec4caae0f) shows much more variety, including "yes" and "true" (and even "hi", blank values, and some unicode symbols!) - and I...

git prompt: Interpret values as true for bools instead of relying on defined-or-not

I'm (also) saying people already have these set from a time before we told them what to set it to. Their configs will break. The results show a bunch of...

git prompt: Interpret values as true for bools instead of relying on defined-or-not

It's nice that this clears up the earlier confusing statement about boolean variables vs git variables.

fish_vi_mode $ command issues with autosuggestions

I guess we can add the `regression` tag as this was working correctly under `2.3b2-120-g3626c39`

fish_clipboard_copy/paste: Handle redirected stdout/stdin

+1 for me; I forgot this wasn't already supported. It's one of the many clipboard-related things I can't live without as part of [my fish config](https://github.com/mqudsi/fish-config). I also have support...

fish_clipboard_copy: use OSC 52 when running inside SSH

Johannes and I spoke about this in person and it's an awesome feature but I have concerns about not calling the traditional fallbacks if the OSC escape isn't supported. I...