script.kodi.hue.ambilight icon indicating copy to clipboard operation
script.kodi.hue.ambilight copied to clipboard

[TODO] Add: experimental auto undim when movie reaches credits

Open ghost opened this issue 9 years ago • 2 comments

experimental auto undim when movie reaches credits (does not always work, may ruin your movie-watching experience)

ghost avatar Oct 02 '16 10:10 ghost

Therefore I'm new to Github I have no idea how to communicate in any other way than commenting on an issue... :D

So, in line 102 and 122 you're reffering to get_credits_info(), can you maybe explain what exactly is happening there. I'm not sure if I understand it correct. Whenever the movie starts playing/is resumed you calculate the time left until the credits?

I really want this addon to be great :)

MrPiggels avatar Dec 08 '16 08:12 MrPiggels

Hello (again) ;)

It's a bit wierd to comment on github, unless you do it on a specific commit / pr, you can't really "comment code" but you can probably either comment existing issues or create a new one with a [FEATURE] or [ENHANCEMENT] tag if you feel like you can "contribute", so you can communicate easily about what you're doing / ask help / whatever and keep that subject grouped ;)

For the code, when you check a file on github you can click the line number (left) to have an url poiting to it, copy/pasting that url will be shorted to "commit-hash@line-number" ;)

For an actual explanation, check here : https://github.com/mpolednik/script.kodi.hue.ambilight/blob/master/default.py#L636 but long story short, It checks the movie chapters (online?) to know when the credits generic start and auto undim the lights.

ghost avatar Dec 08 '16 10:12 ghost