Results 142 comments of Michael Pilquist
trafficstars

@RaasAhsan What's that status of this one?

Agreed, we'll need benchmarks of some form for this - at very least informal ones if not full JMH ones.

Should we release a 3.1.5 with #2671 and then address this later?

If we went the option route, we'd probably need to cache instances of `Some(CRLF)` and `Some(CR)`, right? The Java socket API uses end-of-input and end-of-output. I think either EOF or...

Looking good! Some high level comments: - Is there a way to abstract over `pcap` and `pcapng` if you just want to decode captures? - Note use of Shapeless will...

Yeah, scodec uses HLists on Scala 2 and tuples on Scala 3. There's a little bit of trickery to get the same source cross compiling on both: https://github.com/scodec/scodec/blob/7724ae7efed0ea9e32063b56cf81bd3ffeb381f0/shared/src/main/scala/scodec/compat.scala

@nikiforo Any way I can help get this one over the finish line?

All seem like good options for investigation. Approach 1 seems simplest to me without thinking too much about tradeoffs.