Mike Perham

Results 387 comments of Mike Perham
trafficstars

How much of this traffic could be alleviated with a short-term HTTP cache, e.g. `https://github.com/caddyserver/cache-handler`? Can the webfinger response, toot JSON, generated thumbnails, etc be cached for a few minutes...

Yes this is intentional: while a connection is checked out, further checkouts will return the same connection. It's had this semantic for many years now.

Yeah, I can see some shady edge cases. I wonder if we can write some tests which surface the bad behavior.

This does change the JobLogger constructor. Since that's a breaking change to an internal component, it'll need a minor version bump to 7.3.0.

Yes, it was not deemed important enough option to justify accessors on Sidekiq::Config.

Hmm, I'm getting the OverLimit error as expected. Are you configuring a low read_timeout which conflicts with your 5 sec wait_timeout? > irb(main) $ Sidekiq::Limiter.concurrent('zero_limiter', 0, wait_timeout: 5, lock_timeout: 60).within_limit...

That's how AJ has worked since Rails 4.2. I wonder if they will consider it a bug.

I don't think I can easily build an API that is more effective than using `push_bulk` within the `jobs` block. The only limitation is the inherent race condition triggered by...

Filtering should not turn on Live Poll. That's a bug if true. Is that what you are reporting?

Metrics is not designed to be used with Live Polling at all. You should turn it off and I should remove the ability in a future release.