Include namespace in bound keywords

[nivekuil]

closes https://github.com/mpenet/alia/issues/118

Tested for a while now. I think this is the fastest way to strip the colon from a keyword.

[mpenet]

Can you make sure there is no reflection going on?

Adding a test would also be a good thing.

Thanks

[nivekuil]

ah, there was reflection going on - thanks for catching that! For reference, measured with criterium it's 75ns with reflection, 4ns without. Compare to (subs (str foo) 1) which is 22ns.

I believe I found two bugs while writing the tests, for non-prepared statements in query->statement. First the namespace of the key should be kept as with this patch, and second it must also be double quoted to be used with a / in the name. I think the second is an existing bug, because it would prevent the use of reserved words as keys, e.g. {:values {"view" 1}} would have to be {:values {"\"view\"" 1}}. I added a naive format but this would also break existing users who already quoted these explicitly -- should we be smarter and check if it's already quoted? I added additional tests for reserved words in column names.

[mpenet]

I was thinking about this some more and I am a bit torn. Keywords translate to unquoted identifiers currently, maybe that should remain as is and push the conversion burden to the user, for simplicity's sake. I have to think about it a bit, I ll let it rest for now.

maybe @mccraigmccraig has an opinion on this

[nivekuil]

I think @mccraigmccraig wouldn't be notified if the mention is edited in, fyi