snippets-service icon indicating copy to clipboard operation
snippets-service copied to clipboard

Published 20 hours ago • verified publisher icon mozmeao

Extend addons filtering with addon "disabled" and "enabled" options

Open glogiotatidis opened this issue 7 years ago • 21 comments
trafficstars

Extend issue #343 to include addon enabled and "disabled" options. This is currently blocked by

https://bugzilla.mozilla.org/show_bug.cgi?id=1462124

glogiotatidis avatar May 17 '18 06:05 glogiotatidis

Adding this in 2018Q2 milestone to keep track of it but maybe it gets pushed to Q3 depending on when we get the info available.

glogiotatidis avatar May 17 '18 07:05 glogiotatidis

Info will not be available before Fx62

glogiotatidis avatar May 17 '18 15:05 glogiotatidis

Tried getting the info with

gSnippetsMap.getAddonsInfo().then(info => console.log(info))

and while I get a list of addons, now the disabled addons are not listed at all. The expected outcome would be that the addon is listed the userDisabled is set to true.

We originally discussed this in https://github.com/mozmeao/snippets-service/issues/343#issuecomment-387399040

@k88hudson do you have any insight on this?

glogiotatidis avatar Jul 30 '18 12:07 glogiotatidis

Latest update is that Kate will talk about this with the Addon folks

glogiotatidis avatar Aug 09 '18 12:08 glogiotatidis

@ldwright We won't be getting this implemented for the current system b/c we don't have the required information. The new ASR system will have this. Tracked in #674

glogiotatidis avatar Sep 24 '18 12:09 glogiotatidis

Re-opening b/c this information does not exist in ASR targeting :|

Created new bug 149432

Meanwhile we'll implement only "installed" and "not installed" functionality for ASR to be in par with what we have in current system

glogiotatidis avatar Sep 26 '18 09:09 glogiotatidis

Moving this to Fx64 based on discussion with the ASR team.

glogiotatidis avatar Oct 05 '18 08:10 glogiotatidis

Update in the bug clarifies that this won't be in Fx64 unless uplifted. Will be in Fx65.

glogiotatidis avatar Nov 14 '18 08:11 glogiotatidis

This is still not working on the AS side unfortunately. Commented in bug 149432 and waiting for an update

glogiotatidis avatar Jan 16 '19 08:01 glogiotatidis

New PR to fix this in AS https://github.com/mozilla/activity-stream/pull/4757

glogiotatidis avatar Feb 06 '19 07:02 glogiotatidis

According to the bug this is planned for Fx68 scheduled for 2019-07-09 .

/remind me to check if this has been fixed in nightly in one month

glogiotatidis avatar Feb 27 '19 11:02 glogiotatidis

@glogiotatidis set a reminder for Mar 27th 2019

reminders[bot] avatar Feb 27 '19 11:02 reminders[bot]

:wave: @glogiotatidis, check if this has been fixed in nightly

reminders[bot] avatar Mar 28 '19 06:03 reminders[bot]

The PR https://github.com/mozilla/activity-stream/pull/4757 is still unmerged.

/remind me to check if this has been fixed in nightly in two months

glogiotatidis avatar Apr 01 '19 07:04 glogiotatidis

@glogiotatidis set a reminder for Jun 1st 2019

reminders[bot] avatar Apr 01 '19 07:04 reminders[bot]

Nope, still not landed.

@mozmeao/omn-team is this important? Should we bring it to AS team's attention?

/remind me to check in 2 months

glogiotatidis avatar May 06 '19 08:05 glogiotatidis

@glogiotatidis set a reminder for Jul 6th 2019

reminders[bot] avatar May 06 '19 08:05 reminders[bot]

Yes we should. This is going to become important as we start to target those who are "Caring Confidentials" and "Feature Forward" per Venetia and Cherry's study of our users. Specific Add-ons is one way we can target them. I am still waiting on a specific list from them.

jkt230 avatar May 06 '19 21:05 jkt230

Per last mtg we still want to have this but not high priority

glogiotatidis avatar May 22 '19 08:05 glogiotatidis

:wave: @glogiotatidis, check

reminders[bot] avatar Jul 06 '19 09:07 reminders[bot]

Bug has been de-priotised. let's talk about wanted targeting attributes in 2019H2

glogiotatidis avatar Jul 08 '19 09:07 glogiotatidis