Discuss squashing commits

[codersquid]

trafficstars

Should you recommend squashing commits as a practice for submitting code to review/merge?

[bkatiemills]

To be honest, and maybe I'm a horrible person, I never do this :)

I think it's definitely worth touching on, and fits in the 'crafting a contribution' theme you've been building up. It might be more of a master class point, but will definitely keep it in mind when that content gets developed - thanks as always!

[codersquid]

Perhaps this issue can be closed, unless you want to have some lessons on the mechanics of squashing commits.

If the point of view is someone crafting a contribution to an existing project, emphasizing that someone should review the contributor guidelines of the project is probably good enough. If the maintainors have a strong preference for squashing commits, they'll mention it.

[bkatiemills]

But, there's also a big element in these lessons of helping people set those preferences in the first place; when someone comes to the idea of DVCS for the first time, I would be really impressed if the concept of commit squashing just came to them on their own! I'm going to leave this open under the 'Contrib Crafting' tag, so I remember to consider folding it in to lessons about how to define a great contribution when the time comes - need to finish the intro material first though!