frost icon indicating copy to clipboard operation
frost copied to clipboard

Allow 'xpass' to be an exemption result.

Open hwine opened this issue 5 years ago • 4 comments
trafficstars

Currently, we force all the xfails we add for exemption handling to be "strict" by hard coding the value. This means an exemption will only result in a "pass" or "failed" outcome, as an "xpassed" outcome is converted to "failed" in strict mode.

For a number of scenarios, an "xpassed" for an exemption only means that someone fixed the issue before the exemption expired. In GitHub "xpassed" is handled differently than "failed". (The open issue would be closed with a "thanks" message.)

There are several ways this could be implemented -- how impactful each is depends on current manual use of the "xfail" marker:

  • If no one is manually using "xfail" marker in frost tests (the current case), then we could "simply" remove the hardcoding, and let the value be set via the .ini file (c.f. docs). The default value of xfail_strict could be set to "True" to continue current behavior.
  • If folks are manually using xfail, the same approach could be used, but with a "flag day" to explicitly flip the strict state for manual cases.
  • A new config parameter xfail_strict_for_exemptions could be added.

hwine avatar Aug 17 '20 23:08 hwine

@g-k I'm sure there was a reason to set the value to strict, but I'm unaware of it. Do you remember if the reasoning still matters?

hwine avatar Aug 17 '20 23:08 hwine

I don't remember why Frost runs in strict mode by default. Feel free to change it.

g-k avatar Aug 20 '20 13:08 g-k

@ajvb checking to ensure this won't mess up your processing.

hwine avatar Aug 20 '20 14:08 hwine

@hwine I believe that removing the strict mode should have no impact on our current usage of Frost, so yeah feel free to change.

ajvb avatar Aug 20 '20 16:08 ajvb