frost icon indicating copy to clipboard operation
frost copied to clipboard

Support additional config files

Open hwine opened this issue 6 years ago • 3 comments
trafficstars

Some suites (e.g. GitHub, Heroku) can drive automated escalation sequences. That requires some state to be maintained between runs.

The existing config.yaml file would be suitable for this purpose, but having automation update the repository doesn't feel right (we've been there & done that).

One approach is to add an option to the pytest run where an additional config file(s?) can be specified. That would require:

  • support for read/write of S3 urls
  • clear specification of what 'merging' of configs means
  • clear specification of how the code can access information about the existence of a persistent data store

hwine avatar Jul 08 '19 18:07 hwine

support for read/write of S3 urls

imo, we shouldn't support this within pytest-services. The test runner can do this with ease.

clear specification of what 'merging' of configs means

I don't think we should support merging config files, but rather support additional files that supplement a config value that is a list. Ie, the case of having an additional list of exceptions.

If more than that is needed, it might make sense to add support for some state model that is wholly separate from the current "config file" concept.

ajvb avatar Jul 08 '19 18:07 ajvb

I think we're saying mostly the same thing. I am fine with restricting it to exceptions.

hwine avatar Jul 08 '19 19:07 hwine

Found a workaround for my current needs -- I can use the dates of the issue opened for transient exceptions. I.e. if we give a 3 day grace to correct a branch protection, that's determinable from the issue open date. De-assigning.

hwine avatar Jul 23 '19 20:07 hwine