application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Update to Glean v61.0.0

Open badboy opened this issue 1 year ago • 6 comments

@bendk is coordinating the update.

badboy avatar Aug 21 '24 09:08 badboy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.70%. Comparing base (3760c22) to head (3760c22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6348   +/-   ##
=======================================
  Coverage   52.70%   52.70%           
=======================================
  Files         125      125           
  Lines       12824    12824           
=======================================
  Hits         6759     6759           
  Misses       6065     6065           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 21 '24 09:08 codecov-commenter

This can land as is. a-s is not depending on the Rust parts, so there's no duplicated UniFFI. If #6326 then lands before the next nightly it can land on m-c (you might need to do some additional stuff for the uniffi upgrade?)

badboy avatar Aug 21 '24 15:08 badboy

Okay, so let's merge this and https://github.com/mozilla/application-services/pull/6326, then move to the m-c work? I didn't quite understand the part about the nightly, but this seems like the path to me.

bendk avatar Aug 21 '24 15:08 bendk

Okay, so let's merge this and #6326, then move to the m-c work? I didn't quite understand the part about the nightly, but this seems like the path to me.

a-s gets nightlies and that auto-opens a bug against m-c. Of course those can be manually triggered.

But really all that matters is that we land the Glean, A-S and UniFFI update all together in m-c.

badboy avatar Aug 21 '24 15:08 badboy

a-s gets nightlies and that auto-opens a bug against m-c.

This is the Android nightly right? I don't think there's something like this for Desktop. Does the Android nightly bump update what's vendored in?

In any case, I'll rebase my PR on top of this one and try to get a desktop patch that vendors in that commit. Once those are all approved, I think we should be able to land everything together.

bendk avatar Aug 21 '24 17:08 bendk

a-s gets nightlies and that auto-opens a bug against m-c.

This is the Android nightly right? I don't think there's something like this for Desktop. Does the Android nightly bump update what's vendored in?

Yes, Android. Everything ends up in the same repo so we need that a-s nightly in Android + manual updates for the Desktop parts.

In any case, I'll rebase my PR on top of this one and try to get a desktop patch that vendors in that commit. Once those are all approved, I think we should be able to land everything together.

badboy avatar Aug 22 '24 08:08 badboy