application-services icon indicating copy to clipboard operation
application-services copied to clipboard

DISCO-2947 - Bump UniFFI to 0.28.0

Open bendk opened this issue 1 year ago • 1 comments

WIP for now, I want to double check that the CI passes and we also need to get Glean to update.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [ ] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

bendk avatar Aug 02 '24 16:08 bendk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.28%. Comparing base (eee6c27) to head (24a9db5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6326       +/-   ##
===========================================
+ Coverage   22.00%   49.28%   +27.28%     
===========================================
  Files         342      146      -196     
  Lines       30712    13713    -16999     
===========================================
  Hits         6759     6759               
+ Misses      23953     6954    -16999     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 02 '24 16:08 codecov-commenter

I'm hoping to merge this one today, so that we can have a real mozilla/application-services rev for the moz-central patch for this.

I'll wait until https://github.com/mozilla/application-services/pull/6180 has been merged. That way lougenia can vendor in that one without having to worry about the UniFFI upgrade.

bendk avatar Sep 04 '24 14:09 bendk