application-services icon indicating copy to clipboard operation
application-services copied to clipboard

update Rust for recorded context to handle event store queries

Open jeddai opened this issue 1 year ago • 1 comments

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [x] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [x] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [x] Tests: This PR includes thorough tests or an explanation of why it does not
  • [x] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [x] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

jeddai avatar Jul 30 '24 15:07 jeddai

Codecov Report

Attention: Patch coverage is 20.00000% with 64 lines in your changes missing coverage. Please review.

Project coverage is 21.96%. Comparing base (c8a1a57) to head (78105eb). Report is 473 commits behind head on main.

Files with missing lines Patch % Lines
components/nimbus/src/stateful/targeting.rs 0.00% 29 Missing :warning:
components/nimbus/src/stateful/nimbus_client.rs 0.00% 15 Missing :warning:
components/nimbus/src/error.rs 0.00% 8 Missing :warning:
components/nimbus/src/stateful/behavior.rs 0.00% 5 Missing :warning:
components/nimbus/src/targeting.rs 63.63% 4 Missing :warning:
components/nimbus/src/stateful/evaluator.rs 0.00% 2 Missing :warning:
components/nimbus/src/tests/helpers.rs 90.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6322      +/-   ##
==========================================
- Coverage   21.98%   21.96%   -0.03%     
==========================================
  Files         342      342              
  Lines       30737    30809      +72     
==========================================
+ Hits         6759     6768       +9     
- Misses      23978    24041      +63     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Jul 30 '24 15:07 codecov-commenter