application-services
application-services copied to clipboard
Teach the tabs engine about the ability to close inactive tabs.
This also includes #6281 - you might prefer to review both together or review that by itself, then review this (ie, just the tabs engine changes) once that is merged.
Pull Request checklist
- Breaking changes: This PR follows our breaking change policy
- [ ] This PR follows the breaking change policy:
- This PR has no breaking API changes, or
- There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
- [ ] This PR follows the breaking change policy:
- [ ] Quality: This PR builds and tests run cleanly
- Note:
- For changes that need extra cross-platform testing, consider adding
[ci full]to the PR title. - If this pull request includes a breaking change, consider cutting a new release after merging.
- For changes that need extra cross-platform testing, consider adding
- Note:
- [ ] Tests: This PR includes thorough tests or an explanation of why it does not
- [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
- [ ] Dependencies: This PR follows our dependency management guidelines
- Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.
Branch builds: add [firefox-android: branch-name] to the PR title.
Codecov Report
Attention: Patch coverage is 0% with 149 lines in your changes missing coverage. Please review.
Project coverage is 22.54%. Comparing base (
608b930) to head (1b8b190).
Additional details and impacted files
@@ Coverage Diff @@
## main #6289 +/- ##
==========================================
- Coverage 22.66% 22.54% -0.12%
==========================================
Files 333 329 -4
Lines 29860 29974 +114
==========================================
- Hits 6768 6759 -9
- Misses 23092 23215 +123
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think I got most of the review comments, but still a little unclear on how to proceed re the schema