application-services icon indicating copy to clipboard operation
application-services copied to clipboard

add metrics coroutine scope

Open jeddai opened this issue 1 year ago • 3 comments

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • [ ] This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • [ ] Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • [ ] Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • [ ] Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

jeddai avatar May 28 '24 21:05 jeddai

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.85%. Comparing base (be2d22f) to head (2318e4e). Report is 591 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6255   +/-   ##
=======================================
  Coverage   50.85%   50.85%           
=======================================
  Files         112      112           
  Lines       11811    11811           
=======================================
  Hits         6006     6006           
  Misses       5805     5805           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 28 '24 21:05 codecov-commenter

You may be able to work around this with what you have by putting a blocking coroutine into your serial execution scope first, and have that coroutine wait on engine-gecko to load before it returns

That was ultimately what I planned to do in the Fenix code, I'm just not familiar with the gecko parts of Fenix so I'm not sure what exactly I need to be blocking on.

jeddai avatar Jun 06 '24 12:06 jeddai

You may be able to work around this with what you have by putting a blocking coroutine into your serial execution scope first, and have that coroutine wait on engine-gecko to load before it returns

That was ultimately what I planned to do in the Fenix code, I'm just not familiar with the gecko parts of Fenix so I'm not sure what exactly I need to be blocking on.

That's probably best asked of the Fenix folks, but I think you should probably target something at the end of the "visual completeness queue" around here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt#459

travis79 avatar Jun 06 '24 13:06 travis79