application-services
application-services copied to clipboard
Fixes for cargo audit
- Update h2
- Switch nimbus-fml to clap v3. It would be nice to upgrade it to v4, but this is simple and enough to fix the cargo audit warnings.
Pull Request checklist
- Breaking changes: This PR follows our breaking change policy
- [ ] This PR follows the breaking change policy:
- This PR has no breaking API changes, or
- There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
- [ ] This PR follows the breaking change policy:
- [ ] Quality: This PR builds and tests run cleanly
- Note:
- For changes that need extra cross-platform testing, consider adding
[ci full]to the PR title. - If this pull request includes a breaking change, consider cutting a new release after merging.
- For changes that need extra cross-platform testing, consider adding
- Note:
- [ ] Tests: This PR includes thorough tests or an explanation of why it does not
- [ ] Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
- [ ] Dependencies: This PR follows our dependency management guidelines
- Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.
Branch builds: add [firefox-android: branch-name] to the PR title.
Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.
Project coverage is 82.05%. Comparing base (
63ea144) to head (75266ae).
| Files | Patch % | Lines |
|---|---|---|
| ...ponents/support/nimbus-fml/src/command_line/mod.rs | 0.00% | 22 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #6190 +/- ##
==========================================
- Coverage 84.09% 82.05% -2.04%
==========================================
Files 117 117
Lines 15627 15629 +2
==========================================
- Hits 13141 12825 -316
- Misses 2486 2804 +318
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
302 to @jeddai, since this affects nimbus-cli ☺️
Looks like there's definitely more changes to be had, since this is breaking the nimbus-fml tests. If you point me in the right direction, I think I can fix them. If you want to tackle them yourself that's fine with me as well.
I think the dependency checks are passing nowadays, not sure what changed to make that happen. Should we close this? I don't want to push a clap upgrade on nimbus before you're ready.
Hi so sorry I completely missed this — I'll take a look!
This is no longer an issue with the current main, let's close this.