addons icon indicating copy to clipboard operation
addons copied to clipboard

Unlisted add-on remained in Manual queue after delay rejection

Open iulianacse opened this issue 2 years ago • 6 comments
trafficstars

The unlisted add-on: {3c236fbc-9114-43ed-a224-0cd1834aec4d} The last version of the add-on (0.0.19) was in Awaiting Review state. I sent a delayed rejection expecting the add-on to be removed from the Manual queue. It still has 2 other versions (0.0.13 and 0.0.15) that were flagged by scanner and approved by system, probably why it's still in the queue, but, being an unlisted add-on, there is no way to handle those versions

┆Issue is synchronized with this Jira Task

iulianacse avatar Feb 13 '23 13:02 iulianacse

@iulianacse Unlisted versions need to be looked at individually. You should be able to confirm approval, approve or reject those other versions explicitly, which would clear the flag for them and remove the add-on from the manual review queue.

diox avatar Feb 13 '23 13:02 diox

@iulianacse Unlisted versions need to be looked at individually. You should be able to confirm approval, approve or reject those other versions explicitly, which would clear the flag for them and remove the add-on from the manual review queue.

We cannot reject them, they don't appear in the dropdown in Rejecting Multiple Versions, we can only Confirm the approval

iulianacse avatar Feb 13 '23 14:02 iulianacse

I think that's because it doesn't make sense to reject already approved unlisted versions: if the version is problematic, the idea was that they should be blocked instead. @wagnerand to confirm what to do here, do we need to allow regular (non-blocking) rejection?

This is similar to https://github.com/mozilla/addons/issues/9085 in a way.

diox avatar Feb 13 '23 14:02 diox

Similar case as @iulianacse, add-on {2eea4e1b-1f85-49ac-8b6d-a485f44b58a9}

STR

  • [initial state] Unlisted Add-on is flagged for manual review and is in the manual review queue
  • Reviewer asks for more info using reviewer reply
  • Developer uploads a (couple of) new version that are now in awaiting review state
  • Reviewer reviews the newly uploaded versions
  • Reviewer rejects the versions awaiting review and requests the developer to fix the issues

Expectation

  • Add-on is removed from the manual queue as there's nothing that needs to be done to that add-on

What's happening

  • Add-on stays in the manual queue.
  • The reviewer has no way to send a review verdict for it and get it out of the queue

My assumptions is that it is happening because the flagged version is still un-reviewed, but I could be off here.

abhn avatar Feb 14 '23 15:02 abhn

https://mozilla-hub.atlassian.net/browse/AOP-40 might be a way out for this, but needs a decision and approval.

wagnerand avatar Feb 16 '23 11:02 wagnerand

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-254

KevinMind avatar May 03 '24 17:05 KevinMind