addons icon indicating copy to clipboard operation
addons copied to clipboard

Make the Theme Wizard generate MV3 static themes

Open ioanarusiczki opened this issue 2 years ago • 7 comments
trafficstars

As discussed with diox , I'm opening an issue:

The theme wizard is generating MV2 versions for now

MV3 is coming starting January and submission, installation and updates were tested in QA-1668

At one point in the future, the theme wizard should generate MV3 themes too.

┆Issue is synchronized with this Jira Task

ioanarusiczki avatar Dec 09 '22 13:12 ioanarusiczki

Because of the difficultly of supporting both MV2 and MV3 versions we'll want to wait until the ESR supports MV3 at least.

eviljeff avatar Dec 12 '22 10:12 eviljeff

Note: I'm unaware of anything in the MV3 spec that affects themes, so I'm assuming it's literally just changing 2 to 3 in the manifest.

eviljeff avatar Dec 12 '22 10:12 eviljeff

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-184

KevinMind avatar May 03 '24 17:05 KevinMind

Let's confirm that it's ok to do with web-ext folks but otherwise should be ok. We don't need to care about the existing themes yet.

diox avatar Sep 09 '24 13:09 diox

Let's confirm that it's ok to do with web-ext folks but otherwise should be ok. We don't need to care about the existing themes yet.

Nope, this is not OK yet... https://bugzilla.mozilla.org/show_bug.cgi?id=1917613

willdurand avatar Sep 09 '24 14:09 willdurand

:+1: we are not in a hurry to do it anyway. I've marked this as blocked, we'll want to wait for this to be fixed (and any other blockers we might discover) and probably to be rolled out in the next ESR as well...

diox avatar Sep 09 '24 15:09 diox

https://bugzilla.mozilla.org/show_bug.cgi?id=1917613 has been fixed in Firefox 132. While it was less concerning than initially thought, we'd still recommend to use 132 as the default min version for MV3 themes.

FWIW I've uploaded a MV3 theme on -dev and everything is working flawlessly: installs, updates, etc. But we don't know what has changed between 109 (first version with MV3 support) and 132, so while themes work fine in both Release and Nightly right now, it's possible that some Firefox versions break in a more obvious (and bad) way.

Note also that MV3 dictionaries and langpacks aren't affected by Bug 1917613.

willdurand avatar Sep 23 '24 09:09 willdurand