addons
addons copied to clipboard
mozilla
Consider configuring the user display name also as a unique value
STR:
- Log in to AMO
- Select Edit my Profile from the user menu (https://addons-dev.allizom.org/en-US/firefox/users/edit)
- Set a display name In the Edit profile page and click on Update Profile
- Log in with another account on AMO
- Repeat 2 and 3, making sure that you set the exact same display name for this user as well
Actual result: The profile is successfully updated, allowing an already existent display name to be set
Expected result: The user should be asked to set a different display name if the one he chose is already in use by another user
Notes:
- I think this should be considered as an anti-spam measure (see also the case debated in mozilla/addons#5232 )
- reproduced on all AMO servers with FF60, Win10x64
┆Issue is synchronized with this Jira Task
When there's no display name AMO shows the username, so even if this bug was fixed, you could still set a display name that is the same as somebody else's username.
The real solution™️ here is to have only one field, and make it unique. I filed https://github.com/mozilla/addons/issues/5528 for this, so I'm closing this issue in favor of that one.
We unified username and display name, but display name is still not unique. I'm reopening this issue. We need to figure out what to do about duplicate names, if there are any.
Alright, so this is a much bigger problem that I anticipated. My vote goes for avoiding future dupes, making sure there aren't multiple accounts called Mozilla or Firefox (I'll take this one), and ignoring the backlog.
Alright, so this is a much bigger problem that I anticipated
Are we going to fix this... somehow? (e.g. append a number on the end)? If so, lets have it as a follow-up issue.
Duplicate names aren't a problem on their own. They're only a problem if they are deceptive. I think we can deal with bad dupes manually and leave the backlog as is. Fixing this issue should decrease future instances of this.