addons
addons copied to clipboard
mozilla
[Task]: Allow 2nd level approval decisions to be cancelled
Description
As member of the add-ons operations staff, I'd like to be able to cancel a review decision held for 2nd level approval without making a decision one way or the other.
Example situation
Currently, if a reviewer makes a (certain kind of) review decision against (certain type of) add-on version, the decision gets caught in the 2nd level approval queue.
If the reviewer wishes to undo their decision (for example, if the the original review decision wasn't accurate), there's no "correct" way to resolve the item from the 2nd level approval queue
- Approving it would mark the version is compliant which it might not be.
- Going ahead with the reviewer's decision would record the reviewer's incorrect verdict as correct, which it isn't.
Acceptance Criteria
- [ ] A way to close review decisions held in 2nd level approval queue without making a decision one way or the other. Essentially marking the original review as invalid but not marking the content as compliant.
┆Issue is synchronized with this Jira Task
From triage:
The thinking at the time of implementing 2nd level approval is that the 2nd level approver would make the correction themselves...
We have the concept of "Ignore" action but that applies to the report itself, and here we'd like to ignore the decision that was made, which it slightly different, so it's not trivial to implement.
This needs more discussion with Product & Operations to find the proper fix for this, and see if there are any other things we want to look at regarding 2nd level approval rather than making small incremental steps.
The thinking at the time of implementing 2nd level approval is that the 2nd level approver would make the correction themselves...
We want to cancel the pending decision, not ignore it. There is no way to correct a mistaken action. The only available options are to "Proceed with decision" and "Approve content instead". However, we do not want do either.
This needs more discussion with Product & Operations to find the proper fix for this, and see if there are any other things we want to look at regarding 2nd level approval rather than making small incremental steps.
That work is underway, but we would like this to be prioritized because this is an active issue on production. Can you suggest an alternative to remove that entry from the 2nd level approval queue right now?
We want to cancel the pending decision, not ignore it.
I'm actually understanding it as you want cancel the enforcement of the decision - the decision happened already.
There is no way to correct a mistaken action. The only available options are to "Proceed with decision" and "Approve content instead". However, we do not want do either.
Can you expand on the example? - the situation above says the version may not be compliant, but the reviewers decision isn't correct - and you're saying you don't want to either proceed with the rejection/disable, or say the content is okay. The add-on was in the queue so ultimately you want to do something, so what are the unstated next steps in the example above?
What happened on prod was that the reviewer rejected a version but realized that they had selected the wrong version. That rejection was held for 2nd level approval.
At the time it was unclear what the expected action for that version should be. So another reviewer looked into it and saw some indication that the version might still be out of compliance, but potentially due to a different issue.
Can the decision be undone and the version(s) be put back in the queue?
Can the decision be undone and the version(s) be put back in the queue?
To clarify, the decision should not go through, but it is canceled, using a cancel button on the 2nd level review page. At least at first, this option should only be available for decisions that originate from add-on reviewers, not from Cinder. The Cancel decision must provide a reasoning in a textbox (to be entered by the user). Any abuse reports or appeals closed as part of the decision should be reopened. An activity log should be emitted that the held decision was canceled, along with the reason. The version(s) should be put back into the queue.
@eviljeff
Except for delay reject which throws a 500 , you can try on dev with this decision, the rest of scenarios should be ok.
Maybe I should mention one more aspect:
-> with an abuse report that goes to Cinder and it's being disabled from there, after the job is canceled in rev tools the version is going to be flagged for HR in rev tools with "Re-enqueued in reviewer tools from 2nd level approval". But I think this is also expected.
Also looking over what's been logged in Cinder -> should be good.
(leaving my doc with notes while testing - that's a trace left for me/qa)
