addons icon indicating copy to clipboard operation
addons copied to clipboard

[Task]: There is a blank unused area in the add-ons description AMO

Open marcoagpinto opened this issue 8 months ago • 3 comments
trafficstars

Description

Heya,

There is a huge blank area on the right of the text.

If that space was used, the description of the add-ons wouldn't be too cluttered.

Could it be improved?

Thanks!

Image

Acceptance Criteria

  ### Milestones/checkpoints
  - [ ] A sentence describing the first milestone/checkpoint

Checks

  • [x] If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

marcoagpinto avatar Mar 06 '25 18:03 marcoagpinto

@topotropic is this something we want to consider for the listing page refresh?

context: there's a max-width currently for text content on the listing page.

eviljeff avatar Mar 11 '25 13:03 eviljeff

There are 2 max-width at play:

  • One on the description itself (https://github.com/mozilla/addons/issues/10517)
  • One added afterwards on the box/column

IMHO I agree that we don't need both and could remove the one on the description. It would look slightly better and we'd still have a max to prevent the text from being too wide.

diox avatar Mar 11 '25 13:03 diox

At 700px we show the card in full width and we don’t apply the max-width on the content itself, so yeag I feel like we can get rid of the max-width n the description itself.

willdurand avatar Mar 11 '25 13:03 willdurand

The fix for https://github.com/mozilla/addons/issues/15463 will fix this too (though we are planning to completely redesign the page anyway).

diox avatar Apr 29 '25 14:04 diox

This is fixed , an example this addon on -stage https://addons.allizom.org/en-US/firefox/addon/yomikiri_test/

before

Image

after

Image

ioanarusiczki avatar Apr 30 '25 09:04 ioanarusiczki

It isn't fixed on AMO: https://addons.mozilla.org/en-GB/firefox/addon/british-english-dictionary-2/

marcoagpinto avatar Apr 30 '25 09:04 marcoagpinto

Image

marcoagpinto avatar Apr 30 '25 10:04 marcoagpinto

It isn't fixed on AMO: https://addons.mozilla.org/en-GB/firefox/addon/british-english-dictionary-2/

see the milestone - it will be live on production AMO on 2025.05.01

eviljeff avatar Apr 30 '25 10:04 eviljeff

@eviljeff

Ahhhhh… sorry… Thanks!

marcoagpinto avatar Apr 30 '25 10:04 marcoagpinto

@marcoagpinto Yes, I didn't mention it's on a testing server currently. After 01.05.2025 it will go to production.

This is a preview https://addons.allizom.org/en-US/firefox/addon/british-english-dictionary_tes/ for what's coming, there has been another change for developer comments, they merged with description, that's https://github.com/mozilla/addons/issues/15463

ioanarusiczki avatar Apr 30 '25 11:04 ioanarusiczki

It looks great, thanks!

marcoagpinto avatar Apr 30 '25 11:04 marcoagpinto