addons icon indicating copy to clipboard operation
addons copied to clipboard

[Bug]: Better layout for emails sent when author's appeals are denied

Open ioanarusiczki opened this issue 1 year ago • 6 comments

What happened?

From https://github.com/mozilla/addons/issues/14878 This is reproducible when appeal is denied from Cinder with Uphold decision + comment added in appeal justification field or from rev tools with Deny Appeal + add comment

Emails look like this: Author appeal is denied form revtools

What did you expect to happen?

The appeal justification coming from Cinder or comment added by an add-on reviewer should be separated.

Is there an existing issue for this?

  • [X] I have searched the existing issues

┆Issue is synchronized with this Jira Task

ioanarusiczki avatar Jul 04 '24 14:07 ioanarusiczki

It's tricky because we don't know if the comments will be a single sentence of a whole block of text. The original specification that legal/t&s put together specified it in-line.

eviljeff avatar Jul 08 '24 09:07 eviljeff

Ah ok, I wanted to add that I've noticed at approval of a version that the email has "Comments" included and maybe it would help for this case too but I didn't see specifications before filing this.

comments

ioanarusiczki avatar Jul 08 '24 10:07 ioanarusiczki

@ioanarusiczki is the email in the screenshot actually including the lorem ipsum text? Or was that just an example?

KevinMind avatar Jul 16 '24 14:07 KevinMind

lorem ipsum part is user input, the comment of a reviewer in rev tools but it can also belong to a Cinder moderator.

ioanarusiczki avatar Jul 16 '24 14:07 ioanarusiczki

For visibility: QA also filed https://github.com/mozilla/addons/issues/14905

We think both are low priority for the moment. We can revisit when this goes live.

diox avatar Jul 23 '24 14:07 diox

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

github-actions[bot] avatar Jan 20 '25 01:01 github-actions[bot]