addons-frontend icon indicating copy to clipboard operation
addons-frontend copied to clipboard

Make the search box take all available space for all window sizes

Open diox opened this issue 4 years ago • 5 comments
trafficstars

The menu and search box are placed differently and have different width set are different window sizes. At low (< 500px) horizontal sizes, it gets moved next to the username/register login links, and that seems to work nicely. At large (> 720px) horizontal sizes, it seems to have enough space next to the menu items.

Between those sizes though (between 500px and 720px) it gets messy and we hard to tweak the max-width a couple time to get it to display without causing problems. With the fix for https://github.com/mozilla/addons-frontend/issues/10488 the max-width is set to 140px and that's really short in some sizes.

It looks kinda weird as you approach 720px with all that wasted space and tiny search input. We should find a way for the search box to take all available space. It's fine to keep a max-width to avoid the search box looking too big, but here it really gets used to avoid conflicts with other UI elements and I feel that's not the right approach.

diox avatar May 07 '21 12:05 diox

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Jan 03 '22 21:01 stale[bot]

Hey @diox, can I work on this issue?

BhavyaT-135 avatar Jan 29 '22 13:01 BhavyaT-135

@BhavyaT-135 you can, but you'll have to figure out a solution on your own.

diox avatar Feb 10 '22 11:02 diox

Sure, will try and submit a PR for the same.

BhavyaT-135 avatar Feb 10 '22 11:02 BhavyaT-135

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 06:08 stale[bot]