CI on main started failing, but HEAD originally passed

[hwine]

trafficstars

So this is an issue with the CI pipeline. Timeline in comment

To Do:

• [x] compare messages, 1st failure to latest failure
• [x] verify assumption that there is no code impact
• [ ] apply changes

[tracked internally as ITSEC-211]

[hwine]

Date	Status	Notes
2021-11-30	passing	latest commit to main @0b2dced
2021-11-30	ERROR	unit tests failed to retrieve docker image from AWS
2021-12-02	passing	last successful run
2021-12-03	ERROR	unit test & lint-vet-fmt both missing needed testing modules missing from go test & go vet;
time passes	ERROR	no change - all runs Failing, assuming for same test ERROR as above
2022-03-23	ERROR	latest test, same fails as above (failures brought to our attention)

[ajvb]

So, on 2021-12-02, go 1.16.11 was released - https://go.dev/doc/devel/release#go1.16.minor

I imagine this is what introduced the problem. I tried pinning to 1.16.10 in https://github.com/mozilla-services/autograph/compare/ajvb/fix-circle?expand=1 but that didn't seem to fix it. Will look into it further. I'm guessing it's something silly with Circle.

I also tried just upgrading straight to go 1.17, which does solve this issue, but breaks a few tests. Might be worth doing that upgrade instead, but need to fight with circle a bit more first.

[hwine]

So, on 2021-12-02, go 1.16.11 was released - https://go.dev/doc/devel/release#go1.16.minor

well, there we "go" :smirk: Thanks for looking into this!

I also tried just upgrading straight to go 1.17, which does solve this issue, but breaks a few tests. Might be worth doing that upgrade instead, but need to fight with circle a bit more first.

You leaving the app on 1.16.10, and just moving the tests to 1.17, right? Or moving the whole project to 1.17?