reference-browser icon indicating copy to clipboard operation
reference-browser copied to clipboard

Custom tab - Custom tab functionality works only after a device restart

Open Diana-Rus opened this issue 5 years ago • 2 comments

Pre-requisites:

  • Have R-B set as default browser

Steps to reproduce

  1. Open gmail and open a website a website through it.

Expected behavior

  • The website is opened through Custom Tab.

Actual behavior

  • The website is not opened through Custom Tab. The website is opened directly in the browser.

Device information

  • Android device: Sony Xperia Z5 (Android 7), Samsung Galaxy S9 (Android 8)
  • Reference Browser version: 1.0.2013 (Build #20831206) GV: 76.0a1-20200318041411

GIF: When custom tabs does not work 20200324-112459

When custom tab works 20200324-113421

Note:

  • On the same build at some point the Custom tab was enabled, it seems that after a restart of works correctly. It did not work with by closing and opening the app nor by uninstalling and install the app again and set the default browser.
  • The issue is not reproducible with Samsung Galaxy S9 (Android 8) - Custom tab is applied right after making R-B default.

Diana-Rus avatar Mar 24 '20 09:03 Diana-Rus

I investigated this issue and found that a restart is NOT required, the issues resolves itself after a while or randomly.

The class CustomTabIntentProcessor returns false when process(Intent) is called then suddenly started returning true while debugging. (The call is triggered by IntentReceiverActivity while resolving the intent)

Testing this issue is cumbersome so I left this info if someone else decides working on it, hope this was helpful.

Excuta avatar Mar 27 '20 12:03 Excuta

Hi, issue does not seem to reproduce anymore on RB 1.0.2020 (Build #21330604) GV: 78.0a1-20200509091423 with Sony Xperia Z5 (Android 7). I'll close the ticket. In case this issue reproduces please reopen it. Thanks.

Diana-Rus avatar May 12 '20 09:05 Diana-Rus