firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

[Tab tray] Tab thumbnails' dimensions have changed

Open cpeterso opened this issue 1 year ago • 6 comments

Steps to reproduce

  1. In both the Firefox 127 version from the App Store and a TestFlight Nightly 9000 build, open multiple tabs.
  2. Open the tab tray view.
  3. Rotate the device orientation to see the tab thumbnails in tab tray's portrait and landscape modes.
  4. Compare the dimensions of the thumbnails in the two different Firefox versions.

Expected behavior

The tab thumbnails should not be bigger or smaller than before.

Actual behavior

The thumbnails in Nightly are now;

  • a little taller in portrait orientation
  • and much narrower in landscape orientation
  • and have portrait dimensions in landscape orientation, even though the pages they represent have landscape dimensions.

Device & build information

  • Device: iPhone 15 Plus running iOS 17.5.1
  • Build version: I first saw this change in TestFlight Nightly 9000 (43470).

┆Issue is synchronized with this Jira Task

cpeterso avatar Jul 25 '24 17:07 cpeterso

Screenshot of Firefox 127's tab tray in landscape orientation:

image

cpeterso avatar Jul 25 '24 17:07 cpeterso

Screenshot of TestFlight Nightly 9000 (43470)'s tab tray in landscape orientation:

image

cpeterso avatar Jul 25 '24 17:07 cpeterso

@cpeterso I don't have an iPhone, but a Reddit user posted this screenshot that shows even larger tabs:

Screenshot

ghost avatar Aug 17 '24 21:08 ghost

Just a note: I had already included the screenshot in my comment. I used spoiler tags because the screenshot looks huge on 1080p monitors:

<details>
<summary>Screenshot</summary>
<img src="https://github.com/user-attachments/assets/91bec09e-cfc2-4a5c-8977-79008f80594d"/>
</details>

ghost avatar Aug 19 '24 07:08 ghost

oops. Thanks. I overlooked the collapsed screenshot. In that case, I'll delete my redundant comment.

cpeterso avatar Aug 19 '24 19:08 cpeterso

Another user with huge tabs: https://old.reddit.com/r/firefox/comments/1f20ot1/my_layoutits_terrible/

ghost avatar Aug 27 '24 01:08 ghost

➤ Alina Moldovan commented:

CC Norberto Andres Furlan Orla Mitchell

We tried to reproduce this issue using FF versions: v127, v130, and V9000. Also, I split the unexpected results into 3 issues:

  1. The thumbnails' dimensions much narrowed in landscape orientation
  2. 4 thumbnails on a row while in landscape mode
  3. Huge tabs displayed in the tab tray - Not able to reproduce at all

The following cases were identified:

  1. A different behavior is present depending on the Test Flight channels we use: 1. TF FF beta channel → Clean install, tab tray refactor not enabled:
    1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
    2. → 4 thumbnails on a row while in landscape mode - the issue reproduces
2. TF FF channel: 
  1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue reproduces 
  2. → 4 thumbnails on a row while in landscape mode - the issue doesn't reproduce 

3. Video: 

!v130 - comparation between TF channels.MOV|width=220,height=480,alt="v130 - comparation between TF channels.MOV"!

  1. TF FF beta channel: V127 with and without tab tray refactor being enabled 1. Tab tray refactor not enabled
    1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue reproduce
    2. → 4 thumbnails on a row while in landscape mode - the issue doesn't reproduce
2. Tab tray refactor enabled
  1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce  
  2. → 4 thumbnails on a row while in landscape mode -  the issue reproduce

3. videos: 

!127 - tab tray refactor not enabled.MOV|width=220,height=480,alt="127 - tab tray refactor not enabled.MOV"!

!127 - tab tray refactor enabled.MOV|width=220,height=480,alt="127 - tab tray refactor enabled.MOV"!

  1. TF FF beta channel: V130 with and without tab tray refactor being enabled (same results for v9000 build) 1. Tab tray refactor not enabled
    1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce
    2. → 4 thumbnails on a row while in landscape mode - the issue reproduce
2. Tab tray refactor enabled
  1. → The thumbnails' dimensions much narrowed in landscape orientation - the issue doesn't reproduce  
  2. → 4 thumbnails on a row while in landscape mode -  the issue reproduce  

3. videos: 

!v9000 - tab tray refactor enabed.MOV|width=220,height=480,alt="v9000 - tab tray refactor enabed.MOV"!

!130 - tab ray refactor enabled.MOV|width=220,height=480,alt="130 - tab ray refactor enabled.MOV"!

!v9000 - tab tray refactor not enabed.MOV|width=220,height=480,alt="v9000 - tab tray refactor not enabed.MOV"!

!130 - tab tray refactor not enabled.MOV|width=220,height=480,alt="130 - tab tray refactor not enabled.MOV"!

data-sync-user avatar Aug 28 '24 16:08 data-sync-user

I have the same issue as the other reddit users (edit: iPhone SE first generation, most recent version of Firefox ios: 132.0). I used to have tab thumbnails arranged in two columns. Now, tab thumbnails are stretched out into only one column. D25FBB09-5922-4FD5-87CB-CFE1FAC1F41D

Irefusetoenterausername avatar Nov 02 '24 21:11 Irefusetoenterausername

I have the same issue as the other reddit users (edit: iPhone SE first generation, most recent version of Firefox ios: 132.0). I used to have tab thumbnails arranged in two columns. Now, tab thumbnails are stretched out into only one column. D25FBB09-5922-4FD5-87CB-CFE1FAC1F41D

Just wanted to say thank you for adding to this with more reproduction details (you saying which device was very helpful), I was able to narrow down the issue to users on iOS 15 with certain device screen sizes.

dataports avatar Nov 07 '24 10:11 dataports

I have the same issue as the other reddit users (edit: iPhone SE first generation, most recent version of Firefox ios: 132.0). I used to have tab thumbnails arranged in two columns. Now, tab thumbnails are stretched out into only one column. D25FBB09-5922-4FD5-87CB-CFE1FAC1F41D

Just wanted to say thank you for adding to this with more reproduction details (you saying which device was very helpful), I was able to narrow down the issue to users on iOS 15 with certain device screen sizes.

And thank you very much for your hard work and impressive investigative skills. The fact that I'm running ios 15.7.1 validates that as well. I'm sorry I didn't include it in my first comment, I was fishing for solutions that wouldn't involve updating my ios. Although I know it's good practice, it just seemed like every update would always make things worse for me.

Does this mean that updating my ios to the latest version will solve this issue, even if it's still on the same device (iPhone SE first generation)?

Edit: This is now fixed for me as of the most recent Firefox version on February 27th, 2025.

Irefusetoenterausername avatar Nov 15 '24 08:11 Irefusetoenterausername

Hi, got this as well. Updated Firefox in iOS today and got this annoying change. Got: Firefox 135.0 (50174) iOS version: 17.5.1 iPhone model: iPhone SE (2020) 64 GB - Black (MHGP3CN/A).

If this is a bug, I can live with that, it happens. If it's intentional, I hope the UX guy gets punished by the universe. Hiccups all day, non-stop, or something just as sinister.

Please fix this or give an option to change it.

Image

UMP1R3 avatar Feb 08 '25 19:02 UMP1R3