android-components icon indicating copy to clipboard operation
android-components copied to clipboard

Close #11462: Allow to choose the restore location of a tab in the tabstray.

Open Choucroute-melba opened this issue 3 years ago • 2 comments

Added optional parameters for TabsUseCases.RestoreUseCase that allow the browser to choose the restore location of a tab in the tabstray. Default value is RestoreLocation.END.

This closes mozilla-mobile/fenix#22372

Pull Request checklist

  • [X] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [X] Tests: This PR includes thorough tests or an explanation of why it does not
  • [X] Changelog: This PR includes a changelog entry or does not need one
  • [X] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

Choucroute-melba avatar Jan 02 '22 16:01 Choucroute-melba

This pull request has conflicts when rebasing. Could you fix it @Choucroute-melba? 🙏

mergify[bot] avatar Jan 06 '22 15:01 mergify[bot]

This pull request has conflicts when rebasing. Could you fix it @Choucroute-melba? 🙏

mergify[bot] avatar Sep 23 '22 20:09 mergify[bot]

If still desired, please re-open this PR against the new repo with https://github.com/mozilla-mobile/android-components/pull/11468#pullrequestreview-1144672966 addressed. Thank you for your contribution!

csadilek avatar Oct 31 '22 16:10 csadilek

Hey @Choucroute-melba, we're tidying up the remaining opened PR in this repo since this project moved to a new repository. It is now developed and maintained at: https://github.com/mozilla-mobile/firefox-android.

gabrielluong avatar Oct 31 '22 16:10 gabrielluong