js-deep-for-each icon indicating copy to clipboard operation
js-deep-for-each copied to clipboard

Add architecture ppc64le to travis build

Open zazzel opened this issue 4 years ago • 2 comments

Hi, I had added ppc64le support on Travis-ci and Its been success added and build. Kindly review and merge same.

Changes done are added ppc64le arch.

The Travis ci build logs can be verified from the link below. https://travis-ci.com/github/zazzel/js-deep-for-each Please have a look.

Thank you

zazzel avatar Dec 10 '20 13:12 zazzel

Codecov Report

Merging #44 (fc7e907) into master (5f929ff) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           13        13           
  Branches         4         4           
=========================================
  Hits            13        13           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f929ff...fc7e907. Read the comment docs.

codecov[bot] avatar Dec 10 '20 14:12 codecov[bot]

If the pipeline runs to completion faster on ppc64le than amd64 today as claimed, I don't really mind merging this. We can even drop amd64 for the time being, I guess. However, even though ppc64le is supposed to benefit from faster boot times, the last run of the pipeline took longer than amd64.

@satazor, thoughts? We're in the process of moving the CI to GitHub Actions anyhow.

Background:

  • https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z
  • https://docs.travis-ci.com/user/multi-cpu-architectures/#testing-on-multiple-cpu-architectures

acostalima avatar Dec 14 '20 21:12 acostalima