motion icon indicating copy to clipboard operation
motion copied to clipboard

Published 20 hours ago • verified publisher icon motiondivision

SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior

Open simonkarman opened this issue 1 year ago • 2 comments

Fixes the issue as described in: https://github.com/framer/motion/issues/2578

Feature was introduced in: https://github.com/framer/motion/pull/1877

Changelog:

  • SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior.

simonkarman avatar Oct 23 '24 19:10 simonkarman

@mattgperry The issue is now fixed. I'm happy to provide additional testing or troubleshooting if needed before merging.

Quick question about #1877: Was the decision intentional to implement handleChildMotionValue in HTMLVisualElement rather than DOMVisualElement?

simonkarman avatar Oct 23 '24 20:10 simonkarman

Hi @mattgperry, what is the process of getting this PR merged? The pipeline succeeds and there are no conflicts with the main branch. Let me know if you are able to review and approve this. Or let me know if there is someone else I should reach out to. Thanks!

simonkarman avatar Nov 05 '24 11:11 simonkarman

LGTM - I think SVG attrs/styles needs looking at specifically so I don't mind putting this out with the children thing. Thanks for the PR!

mattgperry avatar Dec 03 '24 14:12 mattgperry