composer icon indicating copy to clipboard operation
composer copied to clipboard

add eval after all to mosaicmllogger

Open ethanma-db opened this issue 1 year ago • 0 comments
trafficstars

What does this PR do?

Add eval after all event to the mosaicmllogger to pass to Mapi. This should only trigger if there is some executing evaluator: https://github.com/mosaicml/composer/blob/55f0b7d1880caaf218a56212e86f174bbc463d12/composer/trainer/trainer.py#L2700

Adding from this doc: https://docs.google.com/document/d/1Rk43aTNFXIUULs0OvTMQGXrV8bJkITmjICyGmMrF2Zc/edit?usp=sharing

What issue(s) does this change relate to?

Before submitting

  • [ ] Have you read the contributor guidelines?
  • [ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • [ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • [ ] Did you update any related docs and document your change?
  • [ ] Did you update any related tests and add any new tests related to your change? (see testing)
  • [ ] Did you run the tests locally to make sure they pass?
  • [ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

ethanma-db avatar Jul 26 '24 16:07 ethanma-db