composer icon indicating copy to clipboard operation
composer copied to clipboard

Logger Destination Refactor

Open eracah opened this issue 3 years ago • 0 comments

This PR:

  • removes log_data from LoggerDestination and its subclasses
  • adds log_metrics, and log_hyperparameters to LoggerDestination to FileLogger, InMemoryLogger, ProgressBarLogger, WandBLogger, and TensorboardLogger
  • Adds log_traces to FileLogger
  • removes data, data_fit, data_epoch, and data_batch from Logger
  • adds log_traces, log_metrics, and log_hyperparameters to Logger
  • replaces all log_data calls with log_metrics, log_hyperparameters, or log_traces calls
  • replaces all data_fit calls with log_hyperparameters
  • replaces all data_epoch and data_batch calls with log_metrics
  • removes all LogLevel stuff except for in log_artifacts
  • reformats how things are logged. Examples below

Reformatting Examples

  • FileLogger before:
[FIT][batch=0]: { "blurpool/num_blurpool_layers": 0, "blurpool/num_blurconv_layers": 0, }
[EPOCH][batch=0]: { "epoch": 0, }
[EPOCH][batch=469]: { "metrics/train/Accuracy": 0.8292, }
  • FileLogger after:
[hyperparameter]: blurpool/num_blurpool_layers: 0 
[hyperparameter]: blurpool/num_blurconv_layers: 0
[metric][batch=0]: trainer/epoch: 0 
[metric][batch=469]: metrics/train/Accuracy: 0.9453 
  • ProgressBarLogger log to console before:
[FIT]: { "blurpool/num_blurpool_layers": 0, "blurpool/num_blurconv_layers": 0, }
[EPOCH][batch=0/512]: { "epoch": 0, }
[EPOCH][batch=469/512]: { "metrics/train/Accuracy": 0.8292, }
  • ProgressBarLogger log to console after:
[hyperparameter]: blurpool/num_blurpool_layers: 0
[hyperparameter]: blurpool/num_blurconv_layers: 0
[batch=0/512]: trainer/epoch: 0
[batch=469/512]: metrics/train/Accuracy: 0.9609

Solves JIRA Issues: CO-585 CO-916 CO-207

eracah avatar Aug 17 '22 00:08 eracah