Morgante Pell
Morgante Pell
Agreed, this would be a very nice (optional) addition. I probably won't have time to work on it soon, but would be happy to review a PR.
I've done a bit of investigation, and my understanding is that GKE actually [automatically](https://cloud.devsite.corp.google.com/kubernetes-engine/docs/concepts/node-pools#drain) drains pods on deleted node pools before deleting the nodes. Is anyone observing different behavior, particularly...
Since the resource has no impact, I don't think this is a major issue either way. You're welcome to file a PR on the gcloud repo.
@halkyon What was the error you made? Reproducing this will likely require us to see your *broken* config.
Since this is working in Terraform 0.12.x but not in 0.13.x I'm inclined to believe this is a Terraform Core issue. We can attempt to workaround it but it's not...
@AlexBulankou Is this for a fresh deploy? What does your module configuration look like?
Yeah I think we need to refactor the firewall rules module a bit. Here's what I'd like to see: 1. Split the core rules logic into its own submodule 2....
Still needs to happen.
You could list: - Make - Go - Terraform - Shellcheck Also it should probably go in the development doc: https://github.com/GoogleCloudPlatform/pci-gke-blueprint/blob/master/docs/development.md
> Perhaps if development.md wasn't easily found we should link to it in contributing.md too? Indeed - that's a good idea.