alfred-workflow-todoist icon indicating copy to clipboard operation
alfred-workflow-todoist copied to clipboard

Notifcation: Couldn't update workflow

Open Code-Remote opened this issue 5 years ago • 24 comments

Description

  1. I got a notification that there was a new update for this workflow available
  2. Downloaded the update via Alfred
  3. When I use the keyword to create a new task and enter the first letter I get a notifcation from Alfred saying

"ALFRED WORKFLOW TODOIST Couldn't update workflow Cannot read property 'length' of null"

  1. When I continue typing and press enter, the task is still created properly. But for each word I type I a get a new notification, sometimes even stack on top of each other and Alfred just shows

"Alfred 4 8x notifications"

  1. I tried to reinstall it again, delete workflow from Alfred 4 and go to github download it again. But then I saw that the version was still 5.8.3 and not 5.8.4

Steps to reproduce

Steps to reproduce the behavior:

  1. Install the new version of Todoist workflow
  2. Use keyword 'todo' and enter any letter
  3. See error

Expected behavior

Don't show this notification with the error

Log:

[21:56:21.852] Alfred Workflow Todoist[Script Filter] Queuing argument 'test'
[21:56:22.887] Alfred Workflow Todoist[Script Filter] Script with argv '(null)' finished
[21:56:22.889] Alfred Workflow Todoist[Script Filter] {"items":[{"uid":"693e9af84d3dfcc71e640e005bdc5e2e","title":"CREATE: test","subtitle":"INBOX","icon":{"path":"icon.png"},"arg":"{\"content\":\"test\",\"priority\":1}","type":"default","valid":true}]}
ALFRED WORKFLOW TODOIST
----------------------------------------
os: 10.15.2 (19C57)
query: "todo test"
node.js: v12.10.0
alfred: 4.07
workflow: 3.8.3
 ...

Code-Remote avatar Jan 02 '20 21:01 Code-Remote

Thanks for letting me know. I am currently working on a big update which fixes a lot of the outstanding issues. The problem you are running into is just with the updater. You can still update by downloading the workforce from github.

Martien

moranje avatar Jan 03 '20 15:01 moranje

I am having this problem as well - it appears something is wrong with Github, as downloading the link for the latest version (https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow) and/or the link at https://github.com/moranje/alfred-workflow-todoist/releases/tag/v5.8.4 is currently giving me a version 5.8.3 file when it is actually downloaded.

Downloading the beta version from Issue #125 (https://github.com/moranje/alfred-workflow-todoist/files/3902539/Alfred.Workflow.Todoist.zip) doesn't have the issue.

stacksjb avatar Jan 06 '20 18:01 stacksjb

Hmm that's not good, I need to sleep right now. I'll have a look tomorrow. Thanks for the feedback

Martien

moranje avatar Jan 06 '20 22:01 moranje

This just happened to me as well. I got a notification that 5.8.4 was available, went to download it, tried to install it, and now am getting the exact same error as OP. As per stacksjb, Installed workflow claims to be 5.8.3 not 5.8.4

smagdali avatar Jan 09 '20 08:01 smagdali

This just happened to me as well. I got a notification that 5.8.4 was available, went to download it, tried to install it, and now am getting the exact same error as OP. As per stacksjb, Installed workflow claims to be 5.8.3 not 5.8.4

Can confirm that the version in #125 works fine.

smagdali avatar Jan 09 '20 08:01 smagdali

Getting the same thing after installing the workflow for the first time.

Just guessing, but shouldn't we have "version": "5.8.4" here https://github.com/moranje/alfred-workflow-todoist/blob/master/dist/workflow/workflow.json#L2 ?

The 5.8.4 release has already been done, so a new corrected 5.8.5 will need to be made?

I can submit a PR if you confirm that this is indeed an issue @moranje

jakubka avatar Jan 18 '20 16:01 jakubka

No the workflow.json is whats used to check for updates against. The process of updating the version in the workflow (.plist) and in the package json is automated.

I would like to release a major version update soon. I'm currently little preoccupied with my newborn son. I'll post something as soon as I'm able.

Martien

moranje avatar Jan 20 '20 19:01 moranje

Should be fixed in the v6.0.0-alpha.3. It should be stable enough to use as your daily driver, I now have tests for 80% of the code base.

If you want to keep receiving updates set todo:setting pre_releases true. I still need to update the docs so not all the changes are documented yet.

Martien

moranje avatar Feb 08 '20 13:02 moranje

Same error. Downloaded by link in Readme

todo:settings pre_releases true NO SUCH SETTING

augustgerro avatar Feb 09 '20 01:02 augustgerro

For me the setting is "todo:settingpre_releases"

stacksjb avatar Feb 09 '20 03:02 stacksjb

@augustgerro the link for the alpha is here.

And @stacksjb is right the setting is a todo:setting pre_releases true (minus the additional s0

moranje avatar Feb 09 '20 06:02 moranje

Heads-up: 6.0.0-alpha.4 is out which fixes two nasty bugs, the updater not picking new prereleases and a very unhelpful blocking error message when the API token hasn't been set yet.

Cheers

moranje avatar Feb 11 '20 22:02 moranje

@augustgerro the link for the alpha is here.

And @stacksjb is right the setting is a todo:setting pre_releases true (minus the additional s0

You mean additional space?

Screen Shot 2020-02-11 at 7 43 23 PM

stacksjb avatar Feb 12 '20 00:02 stacksjb

One other thing I've noticed with this release - it appears you've added some sort of unique identifier to the labels and tags, and the first entry says "refresh cache" - is this permanent/intended to stay or just there as part of the pre/debug releases? Slows down my workflow a bit because I typically hit tab and keep typing, but now I have to arrow down and hit enter on the entry specifically.

Screen Shot 2020-02-11 at 7 49 49 PM

stacksjb avatar Feb 12 '20 00:02 stacksjb

@stacksjb Thanks for reporting back. I agree that the refresh cache shouldn't be the first item. I rely on Alfreds sorting items to most used but doesn't make a whole lot of sense. I fix that in the next alpha. I'll open a new issue when I get around to it.

The id's you see are Todoists ids for that resource. I need it to for the API calls. It's a little ugly but the code I relied on made the workflow a little slower and is error prone. This way the ids are validated by the end user. I figured that in this case functionality over beauty...

Keep any observations coming. I've also integrated an easy way to report bugs into the workflow if you run into any.

Cheers, Martien

moranje avatar Feb 12 '20 15:02 moranje

Hi all, I am also getting the "couldn't update workflow" warning.

jrosen48 avatar May 27 '20 17:05 jrosen48

Is this with the latest beta?

moranje avatar May 28 '20 17:05 moranje

I just downloaded it and I'm also getting this warning

eric-bolton avatar Jun 06 '20 16:06 eric-bolton

Hi @edbltn can you confirm that this is with the latest beta?

moranje avatar Jun 07 '20 20:06 moranje

Is this with the latest beta?

Sorry I missed this - this was with the version available at this link (accessed from the README):

https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow

Is this not the latest beta? Thank you!

jrosen48 avatar Jun 07 '20 21:06 jrosen48

Hey there. Thanks for your work on this.

Just installed and seeing the same error message. I downloaded from the main code page on GH, this is the link: https://github.com/moranje/alfred-workflow-todoist/releases/latest/download/Alfred.Workflow.Todoist.alfredworkflow

It still seems to create tasks but always get the error first. I also see it is not searching old tasks that were not created with the workflow and when they are deleted, they still show up in the search list too.

Thanks again!

JunoCopy avatar Jun 14 '20 06:06 JunoCopy

@jrosen48 @JunoCA No it's not, that's master.

The latest fairly stable release is at:

https://github.com/moranje/alfred-workflow-todoist/releases/download/v6.0.0-beta.1/Alfred.Workflow.Todoist.alfredworkflow

See if that helps.

Martien

moranje avatar Jun 15 '20 19:06 moranje

Awesome, thanks @moranje

Just imported and not seeing any issues i did before. Searching old tasks works too :)

thanks again!

JunoCopy avatar Jun 16 '20 01:06 JunoCopy

I also faced this, the v6 beta1 release seems to fix it.

pat-s avatar Jun 25 '20 20:06 pat-s