go-sftp icon indicating copy to clipboard operation
go-sftp copied to clipboard

Published 20 hours ago • verified publisher icon moov-io

Enable windows tests

Open adamdecaf opened this issue 1 year ago • 6 comments

An alternative to https://github.com/moov-io/go-sftp/pull/188

adamdecaf avatar Feb 14 '24 15:02 adamdecaf

I don't know why they recommended -SwitchLinuxEngine, maybe its an additional (undocumented) flag to -SwitchDaemon.

Let's try with this command:

C:\"Program Files"\Docker\Docker\DockerCli.exe -SwitchDaemon

apapsch avatar Feb 15 '24 12:02 apapsch

Let's forget what I said earlier. I tried DockerCli.exe on my local machine, and -SwitchLinuxEngine switches immediately to Linux containers, no restart needed.

apapsch avatar Feb 15 '24 12:02 apapsch

Per Github runner windows README Docker is already installed. Maybe because you install Docker via choco, this messes things up.

apapsch avatar Feb 15 '24 12:02 apapsch

I was unable to find / run DockerCli.exe without installing Docker CE. Do you know the install path in Windows actions runners?

adamdecaf avatar Feb 15 '24 18:02 adamdecaf

Linux containers seem to be the default, because when I use -SwitchDaemon there's output about using Windows containers. https://github.com/moov-io/go-sftp/actions/runs/7905204936/job/21577274174

adamdecaf avatar Feb 15 '24 19:02 adamdecaf

I've opened an issue with Github Support on why this isn't working.

I may try to publish windows/amd64 images from emberstack/docker-sftp which is already in C#. Testing against multiple servers is a good idea too.

adamdecaf avatar Feb 15 '24 21:02 adamdecaf