Moose
Moose copied to clipboard
moose
Small change for MooseX::Attribute::TypeConstraint::CustomizeFatal
I'm just passing one more argument to _inline_throw_exception. In MooseX::Attribute::TypeConstraint::CustomizeFatal, I'm overriding _inline_throw_exception & using this argument to initialize attribute's value to the default value.
Coverage decreased (-9.89%) to 86.56% when pulling 93d68287656fb575502c79149a42a833eec279d8 on Sweet-kid:master into d5cad95c88db26983020cf190d4a825721ea796c on moose:master.
Coverage decreased (-0.21%) to 96.24% when pulling 93d68287656fb575502c79149a42a833eec279d8 on Sweet-kid:master into d5cad95c88db26983020cf190d4a825721ea796c on moose:master.
Coverage decreased (-0.21%) to 96.24% when pulling 7d4c36b072f729f54bd57c406598e8a008fca6ca on Sweet-kid:master into d5cad95c88db26983020cf190d4a825721ea796c on moose:master.
Coverage decreased (-3.62%) to 92.84% when pulling 7d4c36b072f729f54bd57c406598e8a008fca6ca on Sweet-kid:master into d5cad95c88db26983020cf190d4a825721ea796c on moose:master.
Coverage decreased (-0.21%) to 96.24% when pulling 7d4c36b072f729f54bd57c406598e8a008fca6ca on Sweet-kid:master into d5cad95c88db26983020cf190d4a825721ea796c on moose:master.
The change in coverage is alarming; it would be nice to see these changes covered by tests.
The weird part is that there is no actual behavior change beyond a method that by default ignores the extra argument. So the coverage change is misleading.
On Sun, Apr 26, 2015 at 6:25 PM, Karen Etheridge [email protected] wrote:
The change in coverage is alarming; it would be nice to see these changes covered by tests.
Reply to this email directly or view it on GitHub: https://github.com/moose/Moose/pull/101#issuecomment-96440286
This is apparently for https://github.com/avar/moosex-attribute-typeconstraint-customizefatal/pull/1
@karenetheridge Do you mean that this coveralls is telling about the decreased coverage for avar's module?
@Sweet-kid I was just adding a cross-reference to the other PR that this is meant to go with, since it was not clear.
I think it would be helpful to modify the argument list in the sub definition (https://github.com/Sweet-kid/Moose/blob/master/lib/Moose/Meta/Attribute.pm#L45), so it's clear what the extra argument is meant to be.
Also, shouldn't this extra argument be passed in all the places where _inline_throw_exception is called?
(Also, please add something to Changes.)