Nikos Baxevanis

Results 282 comments of Nikos Baxevanis

As a workaround, it is possible to use the [`Range`](https://msdn.microsoft.com/en-us/library/system.componentmodel.dataannotations.rangeattribute%28v=vs.110%29.aspx) attribute on the test parameter(s): ``` c# [Test, AutoData] public void Test( [System.ComponentModel.DataAnnotations.Range(-1, 1)] int actual) { Assert.True(-1

>don't rely on this behavior in their tests I've rarely seen someone rely on a bug 😊

>It appears that this HashSet is used to prevent the same number from being used multiple times. That's correct. >I'd be happy to submit a PR to limit the size...

>* this solution is bound to HashSet implementation that could change I don't see this as a problem. In fact, the whole implementation of that generator *is* an implementation detail.

> * we will not be able to guarantee uniqueness for the very large sequences (greater than threshold) I don't see this as a problem either, unless we measure the...

I understand that you threw a lot of effort on this, and it is highly appriciated 🎉 --- However, * Is it a *simple* change? * Is this set of...

You did a massive work here, and I think we can use this in place of the `RandomNumericSequenceGenerator` in `Fixture`. Would you mind putting this in a new file named...

Yes, you probably didn't see any tests failing as we haven't done any statistical testing on what we currently have.

I'd rather keep your implementation in a new file as `LcgNumericSequenceGenerator`, and then change the `Fixture` class to use this one instead.

If you do that, I have a few comments for your implementation, but you'd have to move it to a new file first.