moodle-php-apache icon indicating copy to clipboard operation
moodle-php-apache copied to clipboard

Add php.ini modification instructions

Open nadavkav opened this issue 5 years ago • 3 comments

Trying to upload a large course backup into the Moodle docker instance, I was limited by php.ini max upload settings. So I propose adding some instructions about updating php.ini within the running docker

nadavkav avatar Apr 09 '20 09:04 nadavkav

Uhm... don't this need to restart the service for the changes to make effect?

stronk7 avatar Aug 19 '21 15:08 stronk7

You are right @stronk7 , but it was so obvious that I failed to mention it. Revisiting this, I think the initial max upload size should be much higher then what it is today, to support uploading of large course backups for testing purposes out of the box. (our case)

nadavkav avatar Aug 19 '21 16:08 nadavkav

Can we add these settings to https://github.com/moodlehq/moodle-php-apache/blob/master/root/usr/local/etc/php/conf.d/docker-php-moodle.ini as I think they're generally helpful.

Might be nice to have instructions for other settings though.

davidscotson avatar Aug 24 '21 08:08 davidscotson

Hi,

I think that now, both with #162 and #167 (both documented in the main readme) it's pretty easy to add any script and/or php configuration.

So I feel that this can be closed now, thanks for your contribution!

If you think that still we should do something else, don't hesitate to open a new issue / PR.

Ciao :-)

stronk7 avatar Mar 18 '23 18:03 stronk7