monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard

Published 20 hours ago • verified publisher icon mono

Add Visual Studio 2019 enhanced themes

Open JoeRobich opened this issue 6 years ago • 8 comments
trafficstars

I think themes based on the enhanced colors scheme introduced in VS2019 (https://github.com/dotnet/roslyn/pull/31976) would be a nice addition.

Dark+ image

Light+ image

JoeRobich avatar Nov 25 '19 22:11 JoeRobich

Looks great with F# code too

image

nosami avatar Dec 09 '19 11:12 nosami

Do I need to push this branch to origin so that CI can run? Or does it matter since this isn't a functional change?

JoeRobich avatar Dec 09 '19 20:12 JoeRobich

Do I need to push this branch to origin so that CI can run? Or does it matter since this isn't a functional change?

We don't run CI from forks for security reasons. You could request access to the Mono org but I'll create a branch to save some time.

nosami avatar Dec 10 '19 08:12 nosami

Thanks @sevoku. I think I found the right spot to add them.

JoeRobich avatar Dec 12 '19 20:12 JoeRobich

@sevoku I installed the build produced by the CI. The themes were available from the preferences dialog and worked as expected.

JoeRobich avatar Dec 13 '19 17:12 JoeRobich

@sandyarmstrong Please let me know if there is anything else needed for this PR. =)

JoeRobich avatar Jan 07 '20 21:01 JoeRobich

@JoeRobich nothing needed from you, thanks. @jmatthiesen was a consensus reached with regard to naming so we can get this merged?

sandyarmstrong avatar Jan 07 '20 21:01 sandyarmstrong

We're looking at having these replace the default Light and Dark themes, after merging in a few other fixes from the existing Visual Studio Light theme. To clean things up, I think it would be great to merge this work in from the external fork, and then I'll setup a new PR with the next set of changes. @sandyarmstrong, sound good?

jmatthiesen avatar Jan 14 '20 17:01 jmatthiesen