monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard

Handles disposed windows when they are closed while checking windows loop

Open netonjm opened this issue 6 years ago • 8 comments

This fix, adds in the CommandManager some logic to unsuscribe closed native windows. and also adds a try/catch with logging in current OpenWindowListHandler

Fixes VSTS #999372 - System.ObjectDisposedException exception in Foundation.NSObject.get_SuperHandle()

netonjm avatar Oct 28 '19 13:10 netonjm

@monojenkins rebase

netonjm avatar Dec 03 '19 02:12 netonjm

@monojenkins rebase

netonjm avatar Dec 09 '19 11:12 netonjm

@monojenkins rebase

netonjm avatar Jan 07 '20 12:01 netonjm

rebased!

netonjm avatar Jan 14 '20 19:01 netonjm

@monojenkins rebase

Therzok avatar Jan 21 '20 16:01 Therzok

@netonjm @Therzok rebase didn't help, something was wrong with "Build monodevelop" task, maybe reopen pr will rid of the issue

VladyslavKostin avatar Jan 22 '20 10:01 VladyslavKostin

Looks like a problem with the code. The build error is:

MonoDevelop.Ide.Commands/WindowCommands.cs(268,14): error CS0246: The type or namespace name 'Exception' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/runners/2.164.3/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.csproj]

WindowCommands is using Exception but does not have a using System; statement.

mrward avatar Jan 22 '20 11:01 mrward

Fixed build issue and rebased! Thank you guys!

netonjm avatar Jan 22 '20 12:01 netonjm