SkiaSharp icon indicating copy to clipboard operation
SkiaSharp copied to clipboard

Enable Vulkan support in Skia on macOS

Open sowa705 opened this issue 8 months ago • 10 comments

Description of Change

Enable Vulkan support in native library on MacOS

Bugs Fixed

  • Fixes #3202

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • [ ] Has tests (if omitted, state reason in description)
  • [x] Rebased on top of main at time of PR
  • [ ] Merged related skia PRs
  • [ ] Changes adhere to coding standard
  • [ ] Updated documentation

sowa705 avatar Mar 14 '25 18:03 sowa705

Draft for now, I want to do some testing locally before publishing the PR as non-draft

sowa705 avatar Mar 14 '25 18:03 sowa705

/azp run

sowa705 avatar Mar 14 '25 18:03 sowa705

Commenter does not have sufficient privileges for PR 3203 in repo mono/SkiaSharp

azure-pipelines[bot] avatar Mar 14 '25 18:03 azure-pipelines[bot]

Draft for now, I want to do some testing locally before publishing the PR as non-draft

@sowa705 I am working on getting https://github.com/MrJul/Estragonia to work on Mac and, the lack on Vulkan support (in SkiaSharp) is a show stopper. But, wait! You are working to fix my exact problem. I have cloned your PR and am attempting to build the native bits buuuuut, I have no idea how to do that. I will continue Googling but, if you have some guidance, it would be greatly appreciated.

dotnet cake --target=<SOMETHING GOES HERE> --skipExternals=all --supportVulkan=true?

NM. I got it building. Working on testing now...

NicholasFreeman avatar Mar 15 '25 03:03 NicholasFreeman

I was able to build native skia libraries with vk enabled but the rest of the solution is giving me some issues

sowa705 avatar Mar 15 '25 10:03 sowa705

I was able to build native skia libraries with vk enabled but the rest of the solution is giving me some issues

Same here. I patched your changes on to the latest production release (3.116.1) and it builds but, there is a crash in MoltenVK. I have tested several versions of MoltenVK, all have the same crash issue. I can post a stack trace shortly.

NicholasFreeman avatar Mar 15 '25 16:03 NicholasFreeman

/azp run

mattleibow avatar Apr 07 '25 17:04 mattleibow

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

azure-pipelines[bot] avatar Apr 07 '25 17:04 azure-pipelines[bot]

@NicholasFreeman @sowa705 did you ever discover the reason for the crashes?

mattleibow avatar Apr 10 '25 22:04 mattleibow

@NicholasFreeman @sowa705 did you ever discover the reason for the crashes?

@mattleibow Not conclusively, yet. In my use-case (Avalonia on Godot via MrJul.Estragonia), it appear to be an issue with the symbols from MoltenVK not being exported/found. I have not had time to get back to it; If/when I do, I will post updates.

NicholasFreeman avatar Apr 11 '25 03:04 NicholasFreeman