Embeddinator-4000 icon indicating copy to clipboard operation
Embeddinator-4000 copied to clipboard

[general] Confusing command line options to set the compilation target

Open VincentDondain opened this issue 8 years ago • 7 comments

To set the compilation target you can either:

Pass: --dll, --shared, --static

or

--target=VALUE


First of all I believe that if you use --dll and then --static you're overriding the first option, not generating both so that's confusing.

Then when looking at both options and reading descriptions, people might be thinking it's two different things.

Last, in case we do want to keep the --target and the individual options, we'd be missing the --framework option which is important, as well as some other.

Full list of options handled by --target

  • library
  • sharedlibrary
  • dylib
  • framework
  • static
  • staticlibrary

VincentDondain avatar May 01 '17 22:05 VincentDondain

I vote for just using --target and add the values that are not listed in the description.

VincentDondain avatar May 01 '17 22:05 VincentDondain

I think the same @VincentDondain, I would volunteer for overhauling this

realvictorprm avatar May 01 '17 22:05 realvictorprm

The existing arguments are made to be identical across both implementations, so a script can switch between them.

@tritao I'd rather like the proposal to drop all single arguments (they are noisy) in favour of the extensible --target=X one. It's still a good time to clean up before too much documentation and developers/scripts starts to depend on them. Do you see any issue with this ?

spouliot avatar May 02 '17 00:05 spouliot

@spouliot No issue, it's a good idea, iirc the single arguments were added before the general --target option was added and don't make sense to exist anymore.

tritao avatar May 02 '17 09:05 tritao

@realvictorprm are you able to test your changes in the objc branch ? or would you rather just remove them from master and someone else will do the same for the objc branch ?

spouliot avatar May 02 '17 21:05 spouliot

Fixed in objc branch: https://github.com/mono/Embeddinator-4000/pull/288

I'll leave this bug open so it's also fixed in master.

VincentDondain avatar May 08 '17 18:05 VincentDondain

I'm very sorry I missed the message

Am 08.05.2017 20:43 schrieb "Vincent Dondain" [email protected]:

Fixed in objc branch: #288 https://github.com/mono/Embeddinator-4000/pull/288

I'll leave this bug open so it's also fixed in master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mono/Embeddinator-4000/issues/235#issuecomment-299954840, or mute the thread https://github.com/notifications/unsubscribe-auth/AYPM8HE2kzUmzFsDRmX8OIpN4yvTP37uks5r32JagaJpZM4NNfkW .

realvictorprm avatar May 08 '17 22:05 realvictorprm